[ 
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987515#action_12987515
 ] 

Robert Muir commented on LUCENE-2609:
-------------------------------------

{quote}
We can jar up all *.java to reduce the file size. I'm not too concerned about 
the file size but more of the usability of it. If we're doing some service, 
then let's do it properly. If we jar dozens, or tens of dozens of .java files, 
how will users use the .jar? Vs if we just jar the relevant classes that make 
up the framework?
{quote}

But is anyone concerned about the file size of the tests jar?
It just goes into someone's test mechanism, I think if its 7MB this is no 
problem.

Thats why I looked at the changes and felt we are over-engineering this, but 
to only to make things more complex for us...

Also keep in mind that as Grant mentioned, if he wants to use the Solr tests 
jar, it will 
depend upon this lucene tests jar. So I think its safest to include everything, 
otherwise 
the Solr tests jar might not work. I know for sure SolrTestCaseJ4 extends 
LuceneTestCase,
but what else does it use/might it use in the future?



> Generate jar containing test classes.
> -------------------------------------
>
>                 Key: LUCENE-2609
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2609
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 3.0.2
>            Reporter: Drew Farris
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch
>
>
> The test classes are useful for writing unit tests for code external to the 
> Lucene project. It would be helpful to build a jar of these classes and 
> publish them as a maven dependency.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to