[ 
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987530#action_12987530
 ] 

Robert Muir commented on LUCENE-2609:
-------------------------------------

bq. If it will make things any simpler, then let's put all the framework 
classes under src/test/o.a.l/framework and have simple target which jars up 
everything underneath it.

Well i mean sounds good (so do parts of Uwe's idea too).

But, some of this stuff is in packages for a reason, it uses package-private 
hacks to improve test-coverage, etc.
So if we do this, we need to expose lots of things as 'public' and 
@lucene.internal for testing, possibly even whole 
classes (haven't looked in a while).

Currently we use tricks like this often in tests: unlike other software (e.g. 
JRE itself) we don't have a separate impl 
namespace to manage things like this without polluting the API... we have to 
use @internal for a lot of things.

Just saying I don't think its simple, sure if someone wants to do the work to 
reorganize all of this stuff, thats great.
its also a bit scary right before a release, considering modifications of core 
src/java stuff would be involved (how much,
I am not sure).

Do we have to do this for 3.1? Or can we include the huge jar file for 3.1 and 
work on this stuff for a future release?


> Generate jar containing test classes.
> -------------------------------------
>
>                 Key: LUCENE-2609
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2609
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 3.0.2
>            Reporter: Drew Farris
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch
>
>
> The test classes are useful for writing unit tests for code external to the 
> Lucene project. It would be helpful to build a jar of these classes and 
> publish them as a maven dependency.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to