[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987534#action_12987534
]
Shai Erera commented on LUCENE-2609:
------------------------------------
It was just a suggestion. If we have utilities that use package-private API
(though their API can be public) then let's keep them where we are. I don't
want to over-complicate our tests, just because we want to give users (and
ourselves) some useful utilities.
BTW, I modified the target to jar only the *.java files and it resulted in a
1.2 MB file (just .class ones). It's less intimidating, but it still contains
254 classes which is a lot. I wouldn't even know where to start.
To me, what I see with the 'focused' file is that I (think) can easily
understand what should I use for what purpose. We can start with even a smaller
set of files, like _TestUtil, LuceneTestCase and BaseTokenStreamTestCase (and
maybe the MockDirWrapper and RandomIndexWriter?).
Alternatively, we can .jar up all .class files for convenience, and include a
README that describes what you should be looking at when you use this .jar. But
personally, I don't think refactoring to tests will severely affect our ability
to maintain that .jar. Really, it's just renaming of some classes, and/or
adding few more.
> Generate jar containing test classes.
> -------------------------------------
>
> Key: LUCENE-2609
> URL: https://issues.apache.org/jira/browse/LUCENE-2609
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Build
> Affects Versions: 3.0.2
> Reporter: Drew Farris
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch
>
>
> The test classes are useful for writing unit tests for code external to the
> Lucene project. It would be helpful to build a jar of these classes and
> publish them as a maven dependency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
