[
https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987549#action_12987549
]
Grant Ingersoll commented on LUCENE-2883:
-----------------------------------------
I think it makes sense to make function queries a module and expose them more
to Lucene users for a number of reasons.
First off, though, I get the concern about implementation detail versus
interface, but I think the tradeoff is worth it for several reasons.
* Function queries (FQs) already have a pretty stable interface and we have
already worked hard to maintain BWC for them since they are one of the more
common areas that people actually do extend in Solr. In other words, FQs are
already more interface than implementation.
* I've always been stumped as to why more Lucene users don't use them and
instead re-invent the wheel. The fact that it has taken this long frankly
mystifies me
* As a corollary of that, more light on them will make them better, improve
performance, etc.
* I agree with most here that the ability to do this kind of thing is exactly
why we merged.
bq. Hmm I don't really understand that part either. You're concerned that
you'll lose the freedom to add functionality that'd benefit Solr only?
I don't think that is the concern. I think the concern is that if one only has
to worry about implementation details and not about backwards compat, public
API, etc. then it is a lot easier to innovate. It's the equivalent of
refactoring IndexWriter public methods versus the underlying DocumentsWriter.
Remember, in Solr, 99% of the public API is in the Request parameters, not in
Java interface. As long as we maintain BWC for the Request interface (i.e.
&start=0&rows=10&q=foo), we are more or less free to do what we want in the
implementation layer.
In the end, I'm +1 on moving it, but with the distinction that changes in
modules need to account for Solr as well as Lucene.
> Consolidate Solr & Lucene FunctionQuery into modules
> -----------------------------------------------------
>
> Key: LUCENE-2883
> URL: https://issues.apache.org/jira/browse/LUCENE-2883
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.0
>
>
> Spin-off from the [dev list |
> http://www.mail-archive.com/[email protected]/msg13261.html]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
