[ 
https://issues.apache.org/jira/browse/SOLR-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584105#comment-14584105
 ] 

Hoss Man commented on SOLR-7667:
--------------------------------

bq. I'm a fan of the "fail fast and fail hard" approach.

While I share this philosophy in general, it's doesn't really make sense here...

Consider specifically how a system can get in a situation like this:

* a completley new solr install, with no cores/collections
* user configures transientSize=2
* user adds 2 cores which are loadOnStartup=true.  everything is happy
* user adds some more cores which are loadOnStartup=false. everything is still 
happy. the transient cache has automatically closes/opens cores as needed
* user restarts solr. everything is still happy - the 2 loadOnStartup=true 
cores are loaded.
* as requests come in, the transient cache closes/opens cores as needed
* a user adds 1 more new loadOnStartup=true core.  everything is still happy
* as requests come in, the transient cache closes/opens cores as needed
* user restarts solr -- suddenly, solr complains about a configuration error 
... WTF? the configuration hasn't changed? Solr was operating just fine before 
restart, now it says transientSize is too small for the number of cores i have? 
WTF?!?!?!

...the philosophy of "fail fast and fail hard" just doesn't apply here -- 
unless you're going to fail fast and hard in the CoreAdmin and not even let a 
new core be created with loadOnStartup=true unless you count all the 
loadOnStartup=true cores (even the ones that may not currently be loaded due to 
either the trnasient cache or due to the user explicitly closing them).

----

I think the only sane behavior here is that if transientSize is used, the Core 
discovery should prioritize initializing loadOnStartup=true cores and if there 
are more of those then the transientSize=N, it should just pick N to load and 
log a warning about: "Core foo not initialized even though it is 
loadOnStartup=true because transientSize=N exceeded."

> If more cores are loaded at startup than the transient core size, cores 
> become unavailable.
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7667
>                 URL: https://issues.apache.org/jira/browse/SOLR-7667
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.2.1, Trunk
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>
> Edwin Lee from the user's list caught this, the original post is titled 
> "loadOnStartup & transientCoreSize & BUG Report on CoreContainer.java"
> Nice catch Edwin!
> More details to follow:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to