[
https://issues.apache.org/jira/browse/SOLR-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584636#comment-14584636
]
Junhao Li commented on SOLR-7667:
---------------------------------
[[email protected]]
Hi Erick,
After discussion with my colleagues, we come up a solution like it.
Although I like using blockingqueue for this scenario, it involve several code
modification.
Right now, I think that is a simple and long term fix.
We just need to replace the code in CoreContainter.CloserThread.run() to the
code below.
By the way, can this fix back port the solr 4.10.3 ? Thank you.
public void run() {
while (! container.isShutDown()) {
SolrCore removeMe = null;
synchronized (solrCores.getModifyLock()) { // need this so we can wait
and be awoken.
removeMe = solrCores.getCoreToClose();
if( removeMe == null ) { // no use while because closer might have to
wake up when container is down.
try {
log.info("Jae's implementation Revision. Watiing start().");
solrCores.getModifyLock().wait();
} catch (InterruptedException e) {
// Well, if we've been told to stop, we will. Otherwise,
continue on and check to see if there are
// any cores to close.
}
continue;
}
}
for (;
removeMe != null && !container.isShutDown();
removeMe = solrCores.getCoreToClose()) {
try {
removeMe.close();
} finally {
solrCores.removeFromPendingOps(removeMe.getName());
}
}
}
}
> If more cores are loaded at startup than the transient core size, cores
> become unavailable.
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-7667
> URL: https://issues.apache.org/jira/browse/SOLR-7667
> Project: Solr
> Issue Type: Bug
> Affects Versions: 5.2.1, Trunk
> Reporter: Erick Erickson
> Assignee: Erick Erickson
>
> Edwin Lee from the user's list caught this, the original post is titled
> "loadOnStartup & transientCoreSize & BUG Report on CoreContainer.java"
> Nice catch Edwin!
> More details to follow:
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
