[
https://issues.apache.org/jira/browse/LUCENE-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601780#comment-14601780
]
David Smiley commented on LUCENE-6578:
--------------------------------------
I sympathize with [~mikemccand]'s point on GeoOutsideDistance; perhaps instead
the methods could go on GeoShape, and then a shape that doesn't support them
could throw UnsupportedOperationException. I have no strong opinion either
way. Any way, it's "Progress not perfection", ehh Mike?
One thing abstractions _can_ do, is reduce code duplication. The interface
"DistanceStyle" does exactly that -- there are many ways to compute a distance
spatially. This change reduced the patch file by ~40%. Does anyone argue this
specific change was anything less than an improvement?
bq. Attaching revision (yes, I know I should just replace the patch, but people
seem to want to compare patches as well as examine the patch itself)
I'll look at your patch tonight. FYI JIRA does not overwrite patches by the
same name; each one is available. See LUCENE-6191 for an example.
> Geo3d: arcDistanceToShape() method may be useful
> ------------------------------------------------
>
> Key: LUCENE-6578
> URL: https://issues.apache.org/jira/browse/LUCENE-6578
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6578.patch, LUCENE-6578.revised.patch,
> LUCENE-6578.revisedagain.patch
>
>
> I've got an application that seems like it may need the ability to compute a
> new kind of arc distance, from a GeoPoint to the nearest edge/point of a
> GeoShape. Adding this method to the interface, and corresponding
> implementations, would increase the utility of the package for ranking
> purposes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
