[
https://issues.apache.org/jira/browse/LUCENE-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603156#comment-14603156
]
David Smiley commented on LUCENE-6578:
--------------------------------------
This patch is definitely improved; nice job Karl! I'd like to improve it
further and get your opinion -- I'll post your patch as the base and then a
revised one on ReviewBoard so you can easily see the delta and comment on
specifics if you choose to. It's a fair amount of code to examine so I won't
get to it until tonight starting 11pm. If you post further updates today
before 11pm then I'll use that.
A couple things I want to mention now:
(1) the choice of "ArcDistance.INSTANCE" as a means of referring to the a
distance. It's fine but I prefer the approach in Lucene's FilteredQuery in
which the choices are referred via named constants, like
FilteredQuery.RANDOM_ACCESS_FILTER_STRATEGY. This avoids seeing "INSTANCE".
Taking that approach here would mean having a DistanceStyle.ARC_DISTANCE or
perhaps just "DistanceStyle.ARC". What do you think?
(2) GeoPath.distance() has an implementation that confused me until I realized
what it was doing... and I realized that wasn't what came to mind when I saw
the distance method. Perhaps this method should be named distanceAlongPath and
further document that it's from the beginning?
> Geo3d: arcDistanceToShape() method may be useful
> ------------------------------------------------
>
> Key: LUCENE-6578
> URL: https://issues.apache.org/jira/browse/LUCENE-6578
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6578.patch, LUCENE-6578.patch
>
>
> I've got an application that seems like it may need the ability to compute a
> new kind of arc distance, from a GeoPoint to the nearest edge/point of a
> GeoShape. Adding this method to the interface, and corresponding
> implementations, would increase the utility of the package for ranking
> purposes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
