Agreed. Waiting on SOLR-8363 right now. On Thu, Dec 3, 2015, at 02:14 PM, Shalin Shekhar Mangar wrote: > Agreed, what's done is done but in future, let's avoid shoving > anything other than critical bug fixes into release branches. > > On Thu, Dec 3, 2015 at 7:42 PM, Robert Muir <[email protected]> wrote: > > A really strong reason would be to not shove last minute changes right > > before releases. > > > > On Thu, Dec 3, 2015 at 9:08 AM, Anshum Gupta <[email protected]> wrote: > >> I'll admit I committed it thinking it was safe and didn't bring any > >> flakiness into the system but it's not something critical. I'll let the > >> release manager decide if it's fine being released with 5.4. If he thinks > >> otherwise (or someone else has a really strong reason) we can roll this > >> back, though I don't really see a reason unless we see broken builds due to > >> this commit. > >> > >> On Thu, Dec 3, 2015 at 3:07 PM, Adrien Grand <[email protected]> wrote: > >>> > >>> SOLR-8330 is not critical so I don't think it should have been committed > >>> to the 5.4 branch. This gives CI too little time to find problems before > >>> Upayavira cuts a release candidate. > >>> > >>> Le jeu. 3 déc. 2015 à 03:34, Anshum Gupta <[email protected]> a écrit > >>> : > >>>> > >>>> Hi, > >>>> > >>>> I'd like to get SOLR-8330 in for 5.4. I'm currently merging and running > >>>> tests so let me know if I shouldn't be merging this in. > >>>> > >>>> > >>>> On Thu, Nov 26, 2015 at 11:00 PM, Upayavira <[email protected]> wrote: > >>>>> > >>>>> Thanks to Steve and Uwe, we now have both ASF and Policeman Jenkins > >>>>> pointing at the 5.4 branch. > >>>>> > >>>>> Upayavira > >>>>> > >>>>> On Thu, Nov 26, 2015, at 04:10 PM, Upayavira wrote: > >>>>> > thx :-) > >>>>> > > >>>>> > On Thu, Nov 26, 2015, at 04:07 PM, Noble Paul wrote: > >>>>> > > OK . So I need to commit my fixes there. I missed the branch > >>>>> > > creation > >>>>> > > mail > >>>>> > > > >>>>> > > > >>>>> > > On Thu, Nov 26, 2015 at 9:34 PM, Noble Paul <[email protected]> > >>>>> > > wrote: > >>>>> > > > @Upayavira is there a branch created for 5.4 already. I see one > >>>>> > > > already > >>>>> > > > > >>>>> > > > On Thu, Nov 26, 2015 at 2:08 AM, Erick Erickson > >>>>> > > > <[email protected]> wrote: > >>>>> > > >> Do note that this is the Thanksgiving holiday here in the US, > >>>>> > > >> lots of > >>>>> > > >> people are out for the week. Mostly FYI, just don't be surprised > >>>>> > > >> if > >>>>> > > >> you get more traffic on this starting next week ;) > >>>>> > > >> > >>>>> > > >> On Wed, Nov 25, 2015 at 11:35 AM, Timothy Potter > >>>>> > > >> <[email protected]> wrote: > >>>>> > > >>> Ok, those fixes are in 5.4 now, thanks! > >>>>> > > >>> > >>>>> > > >>> On Wed, Nov 25, 2015 at 9:49 AM, Upayavira <[email protected]> > >>>>> > > >>> wrote: > >>>>> > > >>>> I'm for one am okay with these going into 5.4. > >>>>> > > >>>> > >>>>> > > >>>> Upayavira > >>>>> > > >>>> > >>>>> > > >>>> On Wed, Nov 25, 2015, at 05:28 PM, Timothy Potter wrote: > >>>>> > > >>>>> I would like to put SOLR-7169 (also fixes 8267) and SOLR-8101 > >>>>> > > >>>>> into > >>>>> > > >>>>> 5.4. I'll commit to trunk and 5x today ... let me know if > >>>>> > > >>>>> there are > >>>>> > > >>>>> any objections to also including in 5.4 branch > >>>>> > > >>>>> > >>>>> > > >>>>> Tim > >>>>> > > >>>>> > >>>>> > > >>>>> On Wed, Nov 25, 2015 at 6:05 AM, Upayavira <[email protected]> > >>>>> > > >>>>> wrote: > >>>>> > > >>>>> > I shall shortly create the 5.4 release branch. From this > >>>>> > > >>>>> > moment, the feature > >>>>> > > >>>>> > freeze starts. > >>>>> > > >>>>> > > >>>>> > > >>>>> > Looking through JIRA, I see some 71 tickets assigned to fix > >>>>> > > >>>>> > version 5.4. I > >>>>> > > >>>>> > suspect we won't be able to fix all 71 in one week, so I > >>>>> > > >>>>> > expect that the > >>>>> > > >>>>> > majority will be pushed, after this release, to 5.5. > >>>>> > > >>>>> > > >>>>> > > >>>>> > Looking for blockers or critical tickets, I see five > >>>>> > > >>>>> > tickets: > >>>>> > > >>>>> > > >>>>> > > >>>>> > https://issues.apache.org/jira/browse/SOLR-8326 (Anusham, > >>>>> > > >>>>> > Noble) blocker > >>>>> > > >>>>> > "Adding read restriction to BasicAuth + RuleBased > >>>>> > > >>>>> > authorization causes > >>>>> > > >>>>> > issue with replication" > >>>>> > > >>>>> > > >>>>> > > >>>>> > Anusham/Noble - any thoughts on how to resolve this before > >>>>> > > >>>>> > the release? > >>>>> > > >>>>> > > >>>>> > > >>>>> > https://issues.apache.org/jira/browse/SOLR-8035 (Erik) > >>>>> > > >>>>> > critical > >>>>> > > >>>>> > "Move solr/webapp to solr/server/solr-webapp" > >>>>> > > >>>>> > > >>>>> > > >>>>> > This one I know isn't a blocker in any sense. > >>>>> > > >>>>> > > >>>>> > > >>>>> > https://issues.apache.org/jira/browse/SOLR-7901 (Erik) > >>>>> > > >>>>> > critical > >>>>> > > >>>>> > "Add tests for bin/post" > >>>>> > > >>>>> > > >>>>> > > >>>>> > Again, this one does not seem to be something worthy of > >>>>> > > >>>>> > holding back a > >>>>> > > >>>>> > release > >>>>> > > >>>>> > > >>>>> > > >>>>> > https://issues.apache.org/jira/browse/LUCENE-6723 (Uwe) > >>>>> > > >>>>> > critical > >>>>> > > >>>>> > "Date field problems using ExtractingRequestHandler and > >>>>> > > >>>>> > java 9 (b71)" > >>>>> > > >>>>> > > >>>>> > > >>>>> > Uwe, I presume as this relates to Java 9, it isn't a > >>>>> > > >>>>> > blocker? > >>>>> > > >>>>> > > >>>>> > > >>>>> > https://issues.apache.org/jira/browse/LUCENE-6722 (Shalin, > >>>>> > > >>>>> > others), blocker > >>>>> > > >>>>> > "Java 8 as the minimum supported JVM version for > >>>>> > > >>>>> > branch_5x" > >>>>> > > >>>>> > > >>>>> > > >>>>> > Looking at the discussion, there was no consensus here, so > >>>>> > > >>>>> > I will not > >>>>> > > >>>>> > consider this a blocker either. > >>>>> > > >>>>> > > >>>>> > > >>>>> > - o - > >>>>> > > >>>>> > > >>>>> > > >>>>> > So SOLR-8326 and LUCENE-6723 seem to be the ones worthy of > >>>>> > > >>>>> > attention. Anyone > >>>>> > > >>>>> > have comments/observations here? > >>>>> > > >>>>> > > >>>>> > > >>>>> > I will create the branch shortly. > >>>>> > > >>>>> > > >>>>> > > >>>>> > Upayavira > >>>>> > > >>>>> > >>>>> > > >>>>> > >>>>> > > >>>>> --------------------------------------------------------------------- > >>>>> > > >>>>> To unsubscribe, e-mail: [email protected] > >>>>> > > >>>>> For additional commands, e-mail: [email protected] > >>>>> > > >>>>> > >>>>> > > >>>> > >>>>> > > >>>> > >>>>> > > >>>> --------------------------------------------------------------------- > >>>>> > > >>>> To unsubscribe, e-mail: [email protected] > >>>>> > > >>>> For additional commands, e-mail: [email protected] > >>>>> > > >>>> > >>>>> > > >>> > >>>>> > > >>> > >>>>> > > >>> --------------------------------------------------------------------- > >>>>> > > >>> To unsubscribe, e-mail: [email protected] > >>>>> > > >>> For additional commands, e-mail: [email protected] > >>>>> > > >>> > >>>>> > > >> > >>>>> > > >> > >>>>> > > >> --------------------------------------------------------------------- > >>>>> > > >> To unsubscribe, e-mail: [email protected] > >>>>> > > >> For additional commands, e-mail: [email protected] > >>>>> > > >> > >>>>> > > > > >>>>> > > > > >>>>> > > > > >>>>> > > > -- > >>>>> > > > ----------------------------------------------------- > >>>>> > > > Noble Paul > >>>>> > > > >>>>> > > > >>>>> > > > >>>>> > > -- > >>>>> > > ----------------------------------------------------- > >>>>> > > Noble Paul > >>>>> > > > >>>>> > > > >>>>> > > --------------------------------------------------------------------- > >>>>> > > To unsubscribe, e-mail: [email protected] > >>>>> > > For additional commands, e-mail: [email protected] > >>>>> > > > >>>>> > > >>>>> > --------------------------------------------------------------------- > >>>>> > To unsubscribe, e-mail: [email protected] > >>>>> > For additional commands, e-mail: [email protected] > >>>>> > > >>>>> > >>>>> --------------------------------------------------------------------- > >>>>> To unsubscribe, e-mail: [email protected] > >>>>> For additional commands, e-mail: [email protected] > >>>>> > >>>> > >>>> > >>>> > >>>> -- > >>>> Anshum Gupta > >> > >> > >> > >> > >> -- > >> Anshum Gupta > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > -- > Regards, > Shalin Shekhar Mangar. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
