[ 
https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006251#comment-13006251
 ] 

Shai Erera commented on LUCENE-2958:
------------------------------------

A thought -- how about we do the following:
# LineDocSource remains basically as it is today, with a getDocData(String 
line) extendable method for whoever wants
# Instead of introducing those Fillers, you create a HeaderLineDocSource which 
assumes the first line read is the header line, and parses the following ones 
as appropriate. It will create LDS extending getDocData.

This will not introduce a Filler in LDS, and those who don't care about it 
don't need to know about it at all. Also, it will showcase the 'extendability' 
of LDS.

Will that be simpler?

> WriteLineDocTask improvements
> -----------------------------
>
>                 Key: LUCENE-2958
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2958
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-2958.patch, LUCENE-2958.patch, LUCENE-2958.patch
>
>
> Make WriteLineDocTask and LineDocSource more flexible/extendable:
> * allow to emit lines also for empty docs (keep current behavior as default)
> * allow more/less/other fields

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to