[ 
https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doron Cohen updated LUCENE-2958:
--------------------------------

    Attachment: LUCENE-2958.patch

bq. Will that be simpler?
It will be simpler, I admit, but it will harder to manage:
* when re-reading the input file (with repeat=true) special treatment of the 
header line is needed. And cannot assume that the header line exists, because 
there are 1-line files out there without this line, which, is possible, I would 
not like to force recreating, and it is possible.
* the simple LDS as today handles no header line. As such, if there is one, it 
will wrongly treat it as a regular line. But I would like it to be able to 
handle both old files (with no header) and new files, with the header. Mmmm,,, 
e could for that write the header only if it differs from the default header. 
Perhaps this will work.

I'll take a look at that again, meanwhile attaching updated patch with the two 
inner DocDataLineReader's.

> WriteLineDocTask improvements
> -----------------------------
>
>                 Key: LUCENE-2958
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2958
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-2958.patch, LUCENE-2958.patch, LUCENE-2958.patch, 
> LUCENE-2958.patch
>
>
> Make WriteLineDocTask and LineDocSource more flexible/extendable:
> * allow to emit lines also for empty docs (keep current behavior as default)
> * allow more/less/other fields

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to