[
https://issues.apache.org/jira/browse/SOLR-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166792#comment-15166792
]
Shalin Shekhar Mangar commented on SOLR-8722:
---------------------------------------------
Hi Scott, yes this should work fine. Sorry for being out of the loop re:
SOLR-8696. I was travelling back to India and had a terrible jet lag.
bq. Also, what's the right way to handle things if the remote call fails? Will
the code throw before it reaches the wait loop, or should I try to inspect the
response object for errors before deciding to wait? I didn't see any special
handling at other call sites.
Hmm, good question. The processResponses method will throw an exception if
abortOnError=true (which it is, in this case) but the 'async' handling does not
throw any exceptions. So if the remote call fails and the user had specified
the 'async' parameter, the wait loop will still be invoked.
> Don't force a full ZkStateReader refresh on every Overseer operation
> --------------------------------------------------------------------
>
> Key: SOLR-8722
> URL: https://issues.apache.org/jira/browse/SOLR-8722
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Affects Versions: 5.4.1
> Reporter: Scott Blum
> Assignee: Mark Miller
> Labels: patch, performance, solrcloud
> Attachments: SOLR-8722.patch
>
>
> We're doing an unnecessary ZkStateReader forced refresh on all Overseer
> operations. This isn't necessary because ZkStateReader keeps itself up to
> date.
> According to [~shalinmangar]'s analysis, we just need to put a wait loop at
> the end of addReplica to observe the state change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
