[ 
https://issues.apache.org/jira/browse/SOLR-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167405#comment-15167405
 ] 

Scott Blum commented on SOLR-8722:
----------------------------------

No problem!  Welcome back, hope you had a good trip.

What would you suggest in this case?  Spinning for a very long time when the 
remote call might have failed quickly seems bad.  What other handler methods do 
you think demonstrate the correct pattern?  The code can be hard to follow.  
Sometime when you're on IRC I'd love to pick your brain about the code in 
OverseerCollectionMessageHandler & OverseerTaskProcessor.

> Don't force a full ZkStateReader refresh on every Overseer operation
> --------------------------------------------------------------------
>
>                 Key: SOLR-8722
>                 URL: https://issues.apache.org/jira/browse/SOLR-8722
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>    Affects Versions: 5.4.1
>            Reporter: Scott Blum
>            Assignee: Mark Miller
>              Labels: patch, performance, solrcloud
>         Attachments: SOLR-8722.patch
>
>
> We're doing an unnecessary ZkStateReader forced refresh on all Overseer 
> operations.  This isn't necessary because ZkStateReader keeps itself up to 
> date.
> According to [~shalinmangar]'s analysis, we just need to put a wait loop at 
> the end of addReplica to observe the state change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to