[ 
https://issues.apache.org/jira/browse/SOLR-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170092#comment-15170092
 ] 

Shalin Shekhar Mangar commented on SOLR-8722:
---------------------------------------------

bq. What would you suggest in this case? Spinning for a very long time when the 
remote call might have failed quickly seems bad.

I guess the only way is to modify the processResponses method to throw an 
exception in case the async request failed just like how we do it today for 
non-async requests.

bq. What other handler methods do you think demonstrate the correct pattern?

I don't think any of them do :(

> Don't force a full ZkStateReader refresh on every Overseer operation
> --------------------------------------------------------------------
>
>                 Key: SOLR-8722
>                 URL: https://issues.apache.org/jira/browse/SOLR-8722
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>    Affects Versions: 5.4.1
>            Reporter: Scott Blum
>            Assignee: Shalin Shekhar Mangar
>              Labels: patch, performance, solrcloud
>         Attachments: SOLR-8722.patch
>
>
> We're doing an unnecessary ZkStateReader forced refresh on all Overseer 
> operations.  This isn't necessary because ZkStateReader keeps itself up to 
> date.
> According to [~shalinmangar]'s analysis, we just need to put a wait loop at 
> the end of addReplica to observe the state change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to