[
https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200349#comment-15200349
]
David Smiley commented on SOLR-8765:
------------------------------------
I think this issue introduced a possible problem, very likely unintended as
it's easy to overlook. This is a new convenience method we are to use (or a
like-kind constructor):
{code:java}
public static Create createCollection(String collection, String config, int
numShards, int numReplicas) {
{code}
Notice that numShards is a primitive int. And notice that Create.numShards is
an object Integer. the setNumShards method is deprecated so I'll overlook that
as I'm not to call it. So how am I supposed to use this for the implicit
router in which my intent is to manage the shards myself, without setting
numShards? Perhaps we shall have a separate convenience method & constructor
expressly for the implicit router?
> Enforce required parameters in SolrJ Collection APIs
> ----------------------------------------------------
>
> Key: SOLR-8765
> URL: https://issues.apache.org/jira/browse/SOLR-8765
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Fix For: 6.1
>
> Attachments: SOLR-8765-splitshard.patch, SOLR-8765-splitshard.patch,
> SOLR-8765.patch, SOLR-8765.patch
>
>
> Several Collection API commands have required parameters. We should make
> these constructor parameters, to enforce setting these in the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
