[
https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200403#comment-15200403
]
Anshum Gupta commented on SOLR-8765:
------------------------------------
numShards shouldn't be mandatory and so the constructor should have excluded
that. I think we need tests for all of this else we wouldn't know what's even
broken.
Ideally, something that randomizes the getting of CollectionsAdminRequest
objects through the deprecated constructor and the new approach would be good,
but that could be a lot of effort to manage a deprecated API, so guess we
should just add more tests for the new API.
> Enforce required parameters in SolrJ Collection APIs
> ----------------------------------------------------
>
> Key: SOLR-8765
> URL: https://issues.apache.org/jira/browse/SOLR-8765
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Fix For: 6.1
>
> Attachments: SOLR-8765-splitshard.patch, SOLR-8765-splitshard.patch,
> SOLR-8765.patch, SOLR-8765.patch
>
>
> Several Collection API commands have required parameters. We should make
> these constructor parameters, to enforce setting these in the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
