[ 
https://issues.apache.org/jira/browse/LUCENE-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209738#comment-15209738
 ] 

Nicholas Knize commented on LUCENE-7094:
----------------------------------------

bq. I see it’s used to put DocValue data in separate field names from the field 
name given to the strategy.  Why this change? 

It's necessary to cut over from {{UninvertingReader}} - which still works on 
5.x segments - to DocValues. If you just set {{DocValues.NUMERIC}} on a 
DoubleField the {{Double.longValue}} is what's stored as the DocValue (aka the 
truncated value). 

bq. I think BBoxStrategy.ComboField (private) shouldn’t be deprecated

It's unnecessary - especially once legacy numerics are removed in 7.0 since 
Point types lock down the FieldType. There is no need to Circumvent Field 
limitations, anyway.

bq. The SpatialStrategy.get/setFieldType option you added is only used by 
BBoxStrategy. 

I'm actually in favor of removing this altogether. I just left it for 
backcompat with applications that need it to circumvent field limitations. I 
meant to take it back out of PVS. I'll make that change. 

bq. I see some {{false &&}} conditions

Good catch! Missed that. 

bq. arguably PVS should enable this by default since without it, one can't even 
do a circle query.

+1




> spatial-extras BBoxStrategy and (confusingly!) PointVectorStrategy use legacy 
> numeric encoding
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7094
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7094
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Nicholas Knize
>         Attachments: LUCENE-7094.patch
>
>
> We need to deprecate these since they work on the old encoding and provide 
> points based alternatives.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to