Github user dsmiley commented on the issue:

    https://github.com/apache/lucene-solr/pull/49
  
    Just one thing -- have compare() take the FunctionValue so that a compare 
impl can choose to call doubleVal vs longVal or whatever else.  And the impls 
you add to Solr can call doubleVal.  Someone truly might want to extend this to 
call something other than doubleVal; the set of values of doubleVal is disjoint 
from longVal.  Or maybe someone has got the data in objectVal for some reason.
    
    After that please post a .patch file to JIRA.  
https://wiki.apache.org/lucene-java/HowToContribute#Creating_a_patch   though 
those instructions should be modified to indicate how to generate a diff from 
the point the current branch diverged from master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to