Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/49
Sorry but I think it's terrible to invoke both doubleVal & longVal
potentially twice per doc on the same FunctionValues. I think what I suggested
in earlier feedback is much closer -- let the subclass choose which
longVal/doubleVal/whatever to call and to make whatever comparison needed. On
the Solr end... we could always work with the doubles, even though some 'long'
values are out of range. I believe some other FunctionValue impls are
implemented similarly as well (?), despite not representing say Long.MAX_VALUE.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
