Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/49
I think at the Lucene level we should make this widely useful by simply
exposing a boolean compare(FunctionValues lhs, FunctionValues rhs). If we go
the way of your latest commit, it would be less useful as some potential users
would skip over it to avoid the performance overhead of calling double &
longVal, or because they have more interesting requirements and want to call
some other method on functionValues. So lets not tie their hands.
Yes my concern is definitely performance based. These things are
super-sensitive to it as it operates once per matching document, which could be
a ton.
What you could perhaps do at the Solr layer is check if both the lhs & rhs
extend from LongDocValues and if so then use the Long version... otherwise use
the Double version which I think can represent Integer completely. But it'd be
very nice not to do that double instanceof check at every comparison... so
perhaps that would lead to actually implementing getValues().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
