[
https://issues.apache.org/jira/browse/LUCENE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018956#comment-13018956
]
Michael McCandless commented on LUCENE-2956:
--------------------------------------------
Patch looks great Simon!
Very impressive how this patch makes delete handling fully lockless!
The inline comments are very helpful...
Some small stuff:
* I think we do need delete-by-Term[] (and Query[]) to be atomic?
(IW has these methods, and I think they are atomic now?) This is
from the TODOs in DocumentsWriterDeleteQueue...
* Does TestRollingUpdates really need to use LogMP?
* raceing -> racing; {@link BuffereDeletes} -> {@link
BufferedDeletes}; DocumensWriter -> DocumentsWriter
> Support updateDocument() with DWPTs
> -----------------------------------
>
> Key: LUCENE-2956
> URL: https://issues.apache.org/jira/browse/LUCENE-2956
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: Realtime Branch
> Reporter: Michael Busch
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: Realtime Branch
>
> Attachments: LUCENE-2956.patch
>
>
> With separate DocumentsWriterPerThreads (DWPT) it can currently happen that
> the delete part of an updateDocument() is flushed and committed separately
> from the corresponding new document.
> We need to make sure that updateDocument() is always an atomic operation from
> a IW.commit() and IW.getReader() perspective. See LUCENE-2324 for more
> details.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
