[ 
https://issues.apache.org/jira/browse/LUCENE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019234#comment-13019234
 ] 

Simon Willnauer commented on LUCENE-2956:
-----------------------------------------

bq. Though it worries me a little how complex the whole delete/update logic is 
becoming (not only the part this patch adds).
I can not more agree. Its been very complex making all the tests pass and 
figuring out all the little nifty cornercases here. A different, somewhat 
simpler approach would be great. Eventually for Searchable Ram Buffers we might 
need to switch to seq. ids anyway but I think for landing DWPT on trunk we can 
go with the current approach. 
I will update the latest patch and commit it to the branch and merge with trunk 
again. Once that is done I will setup a hudson build for RT so we give it a 
little exercise while we prepare moving to trunk.

 

> Support updateDocument() with DWPTs
> -----------------------------------
>
>                 Key: LUCENE-2956
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2956
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: Realtime Branch
>            Reporter: Michael Busch
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: Realtime Branch
>
>         Attachments: LUCENE-2956.patch
>
>
> With separate DocumentsWriterPerThreads (DWPT) it can currently happen that 
> the delete part of an updateDocument() is flushed and committed separately 
> from the corresponding new document.
> We need to make sure that updateDocument() is always an atomic operation from 
> a IW.commit() and IW.getReader() perspective.  See LUCENE-2324 for more 
> details.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to