[ https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733334#comment-15733334 ]
Steve Rowe commented on LUCENE-7585: ------------------------------------ The patch appears to be against a non-existent version of {{CommonAnalysisFactoryParams.java}}, so doesn't apply properly. Manual repair worked for me (saving the patch as the target file, trimming to include just the target file contents, removing {{-}} lines, and deleting {{+}} prefixes from lines). It'd be nice to alphabetize the constants. Otherwise, +1. > Interface for common parameters used across analysis factories > -------------------------------------------------------------- > > Key: LUCENE-7585 > URL: https://issues.apache.org/jira/browse/LUCENE-7585 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis > Affects Versions: 6.3 > Reporter: Ahmet Arslan > Assignee: David Smiley > Priority: Minor > Fix For: master (7.0) > > Attachments: LUCENE-7585.patch > > > Certain parameters (String constants) are same/common for multiple analysis > factories. Some examples are {{ignoreCase}}, {{dictionary}}, and > {{preserveOriginal}}. These string constants are handled inconsistently in > different factories. This is an effort to define most common constants in > ({{CommonAnalysisFactoryParams}}) interface and reuse them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org