[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749577#comment-15749577
]
Ahmet Arslan commented on LUCENE-7585:
--------------------------------------
By saying inconsistency, I mean the strategy to retrieve those parameters from
the arg map. Some use inline string constant e.g. getBoolean(args, "reverse");
others define private or public static final String for the key.
> Interface for common parameters used across analysis factories
> --------------------------------------------------------------
>
> Key: LUCENE-7585
> URL: https://issues.apache.org/jira/browse/LUCENE-7585
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 6.3
> Reporter: Ahmet Arslan
> Assignee: David Smiley
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE-7585.patch, LUCENE-7585.patch
>
>
> Certain parameters (String constants) are same/common for multiple analysis
> factories. Some examples are {{ignoreCase}}, {{dictionary}}, and
> {{preserveOriginal}}. These string constants are handled inconsistently in
> different factories. This is an effort to define most common constants in
> ({{CommonAnalysisFactoryParams}}) interface and reuse them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
