[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15739000#comment-15739000
]
David Smiley commented on LUCENE-7585:
--------------------------------------
RE documentation-lint: It appears they need javadocs then.
(quoting from your description)
bq. These string constants are handled inconsistently in different factories
Can you give an example of how the same parameter is handled differently?
AFAICT This patch doesn't address that. Such inconsistencies, if they exist,
would be more important to resolve than moving Strings constants to an
interface IMO.
I think limiting the scope of this patch to _common_ parameters is well enough.
In doing so, they can be documented in one place (please do that). I'm not
sure what value/point there is in doing anything more with other parameters
(used by one class), or trying to overcome any inter-package complications. So
minGramSize etc. could just be defined in the same common one. At least that's
my opinion; it's kind of a bike-shed issue of taste.
> Interface for common parameters used across analysis factories
> --------------------------------------------------------------
>
> Key: LUCENE-7585
> URL: https://issues.apache.org/jira/browse/LUCENE-7585
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 6.3
> Reporter: Ahmet Arslan
> Assignee: David Smiley
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE-7585.patch, LUCENE-7585.patch
>
>
> Certain parameters (String constants) are same/common for multiple analysis
> factories. Some examples are {{ignoreCase}}, {{dictionary}}, and
> {{preserveOriginal}}. These string constants are handled inconsistently in
> different factories. This is an effort to define most common constants in
> ({{CommonAnalysisFactoryParams}}) interface and reuse them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
