[
https://issues.apache.org/jira/browse/LUCENE-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925894#comment-15925894
]
Michael McCandless commented on LUCENE-7671:
--------------------------------------------
I think, given the added complexity here, we should make a whole new
merge policy, and leave the existing {{UpgradeIndexMergePolicy.java}}
as is?
Can you also add getters when you add a setter (e.g. {{setMaxUpgradesAtATime}}?
Instead of two booleans {{setUpgradeInProgress}} and
{{setRequireExplicitUpgrades}}, can't we just have one (i.e., it's
always explicit)? Maybe rename it to {{setEnableUpgrades}}? The CLI
tool would just enable that.
If {{ignoreNewSegments}} is {{true}}, and {{requireExplicitUpgrades}}
is true but {{upgradeInProgress}} is false, it looks like with this
patch we will fail to carry out the wrap'd MP's force merge request?
Typo in the javadocs for {{setMaxUpgradesAtATime}}: natrually -> naturally
> Enhance UpgradeIndexMergePolicy with additional options
> -------------------------------------------------------
>
> Key: LUCENE-7671
> URL: https://issues.apache.org/jira/browse/LUCENE-7671
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Keith Laban
>
> Enhance UpgradeIndexMergePolicy to be a MergePolicy that can be used outside
> the scope the IndexUpgrader.
> The enhancement aims to allow the UpgradeIndexMergePolicy to:
> 1) Delegate normal force merges to the underlying merge policy
> 2) Enable a flag that will explicitly tell UpgradeIndexMergePolicy when it
> should start looking for upgrades.
> 3) Allow new segments to be considered to be merged with old segments,
> depending on underlying MergePolicy.
> 4) Be configurable for backwards compatibility such that only segments
> needing an upgrade would be considered when merging, no explicit upgrades.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
