[ 
https://issues.apache.org/jira/browse/LUCENE-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930202#comment-15930202
 ] 

Keith Laban commented on LUCENE-7671:
-------------------------------------

How would you feel about removing some of the complexity if we are going to 
split it out into a separate merge policy? A lot of added complexity here was 
to make it compatible with the previous version. E.g. ignoreNewSegments will 
conform to the old behavior of only considering segments needing upgrade as 
merge candidates.

Ideally this merge policy will have the options:

- setEnableUpgrades
- setMaxUpgradesAtATime


And the behavior should be:

- Delegate to the wrapped MP UNLESS enableUpgrades is set
- When enabledUpgrades is set first delegate to wrap'd MP then rewrite (no 
merge) old segments in new format

> Enhance UpgradeIndexMergePolicy with additional options
> -------------------------------------------------------
>
>                 Key: LUCENE-7671
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7671
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Keith Laban
>
> Enhance UpgradeIndexMergePolicy to be a MergePolicy that can be used outside 
> the scope the IndexUpgrader.
> The enhancement aims to allow the UpgradeIndexMergePolicy to:
> 1) Delegate normal force merges to the underlying merge policy
> 2) Enable a flag that will explicitly tell UpgradeIndexMergePolicy when it 
> should start looking for upgrades.
> 3) Allow new segments to be considered to be merged with old segments, 
> depending on underlying MergePolicy.
> 4) Be configurable for backwards compatibility such that only segments 
> needing an upgrade would be considered when merging, no explicit upgrades.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to