[
https://issues.apache.org/jira/browse/SOLR-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926798#comment-15926798
]
Andrzej Bialecki commented on SOLR-9959:
-----------------------------------------
The first round of changes removed getDocs, getSource and getVersion, which
rarely (if ever) provided any useful information. The old JMX reporting
mechanism via {{JmxMonitoredMap}} has been removed as well in favor of the new
{{JmxReporter}}.
After initial investigation it looks like it's possible to completely replace
{{SolrInfoMBean.getStatistics()}} with metrics. There will be some back-compat
breakage (e.g. it's unlikely that the bean names will be preserved in the
output of /admin/mbeans) but the benefit will be a great simplification of the
code and bringing all statistics under the same metrics API umbrella. I'll
continue making changes towards that goal.
I created a branch {{jira/solr-9959}} where I keep the current state of changes
- I welcome all interested parties ([~otis], [~wunder], [[email protected]],
[~romseygeek], others?) to review and chime in, the sooner the better :)
> SolrInfoMBean-s category and hierarchy cleanup
> ----------------------------------------------
>
> Key: SOLR-9959
> URL: https://issues.apache.org/jira/browse/SOLR-9959
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: master (7.0)
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Blocker
> Fix For: master (7.0)
>
>
> SOLR-9947 changed categories of some of {{SolrInfoMBean-s}}, and it also
> added an alternative view in JMX, similar to the one produced by
> {{SolrJmxReporter}}.
> Some changes were left out from that issue because they would break the
> back-compatibility in 6.x, but they should be done before 7.0:
> * remove the old JMX view of {{SolrInfoMBean}}-s and improve the new one so
> that it's more readable and useful.
> * in many cases {{SolrInfoMBean.getName()}} just returns a FQCN, but it could
> be more informative - eg. for highlighter or query plugins this could be the
> symbolic name of a plugin that users know and use in configuration.
> * top-level categories need more thought. On one hand it's best to minimize
> their number, on the other hand they need to meaningfully represent the
> functionality of components that use them. SOLR-9947 made some cosmetic
> changes, but more discussion is necessary (eg. QUERY vs. SEARCHHANDLER)
> * we should consider removing some of the methods in {{SolrInfoMBean}} that
> usually don't return any useful information, eg. {{getDocs}}, {{getSource()}}
> and {{getVersion()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
