[
https://issues.apache.org/jira/browse/SOLR-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957234#comment-15957234
]
Hoss Man commented on SOLR-9959:
--------------------------------
bq. The config can specify multiple groups or registry names, or registry name
prefixes that it applies to, and for each matching unique registry name a
separate reporter instance will be created.
ok ... seems weird, but i'll take your word for it that it's expected ... my
main concern was that we weren't excessively and unneccessarily
"re-registering" equivilent MBeans with the MBean server every time a
(seemingly duplicate) SolrJmxReporter was created ... if you're saying that's
not happening then i'll take your word for it.
bq. JmxObjectNameFactory uses registry name as domain (if domain is not set),
and it also inserts reporter's name (as configured in the plugin config) in the
hierarchy, so for each reporter instance and for each registry the hierarchy is
unique.
I'm not sure i follow -- largely because i'm still not really clear what you
mean by "registry name" and "domain" -- to be clear about what I saw (as an end
user) and what i'm suggesting:
* Sample current ObjectNames (with implicit default reporter) ...
**
{{solr:dom1=core,dom2=techproducts,reporter=default,instance=6fd59eb3,category=CACHE,name=fieldCache}}
**
{{solr:dom1=core,dom2=techproducts,reporter=default,instance=6fd59eb3,category=SEARCHER,scope=searcher,name=maxDoc}}
**
{{solr:dom1=node,reporter=default,instance=4007f65e,category=CONTAINER,scope=threadPool,name=coreContainerWorkExecutor.completed}}
* Suggested replacement ObjectNames for the same MBeans (with implicit default
JMX reporter) ...
** {{solr:dom1=core,dom2=techproducts,category=CACHE,name=fieldCache}}
**
{{solr:dom1=core,dom2=techproducts,category=SEARCHER,scope=searcher,name=maxDoc}}
**
{{solr:dom1=node,category=CONTAINER,scope=threadPool,name=coreContainerWorkExecutor.completed}}
* Suggested replacement ObjectNames for the same MBeans (with explicitly
configured JMX reporter using reporter name "HOSSJMX") ...
** {{HOSSJMX:dom1=core,dom2=techproducts,category=CACHE,name=fieldCache}}
**
{{HOSSJMX:dom1=core,dom2=techproducts,category=SEARCHER,scope=searcher,name=maxDoc}}
**
{{HOSSJMX:dom1=node,category=CONTAINER,scope=threadPool,name=coreContainerWorkExecutor.completed}}
> SolrInfoMBean-s category and hierarchy cleanup
> ----------------------------------------------
>
> Key: SOLR-9959
> URL: https://issues.apache.org/jira/browse/SOLR-9959
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: master (7.0)
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-9959.patch, SOLR-9959.patch
>
>
> SOLR-9947 changed categories of some of {{SolrInfoMBean-s}}, and it also
> added an alternative view in JMX, similar to the one produced by
> {{SolrJmxReporter}}.
> Some changes were left out from that issue because they would break the
> back-compatibility in 6.x, but they should be done before 7.0:
> * remove the old JMX view of {{SolrInfoMBean}}-s and improve the new one so
> that it's more readable and useful.
> * in many cases {{SolrInfoMBean.getName()}} just returns a FQCN, but it could
> be more informative - eg. for highlighter or query plugins this could be the
> symbolic name of a plugin that users know and use in configuration.
> * top-level categories need more thought. On one hand it's best to minimize
> their number, on the other hand they need to meaningfully represent the
> functionality of components that use them. SOLR-9947 made some cosmetic
> changes, but more discussion is necessary (eg. QUERY vs. SEARCHHANDLER)
> * we should consider removing some of the methods in {{SolrInfoMBean}} that
> usually don't return any useful information, eg. {{getDocs}}, {{getSource()}}
> and {{getVersion()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
