[
https://issues.apache.org/jira/browse/SOLR-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956597#comment-15956597
]
Andrzej Bialecki commented on SOLR-9959:
-----------------------------------------
Again, thanks a lot for the detailed review, most of these issues are
straightforward to fix.
Some clarification only about how reporters are now configured in {{solr.xml}}:
each {{<reporter>}} element defines a configuration and not an instance. The
config can specify multiple groups or registry names, or registry name prefixes
that it applies to, and for each matching unique registry name a separate
reporter instance will be created. This indeed allows you to configure
per-collection reporters that report to different destinations, or multiple
reporters for the same collection that report to different destinations. So the
multiple reporter instances that you saw are normal and expected.
JmxObjectNameFactory uses registry name as domain (if domain is not set), and
it also inserts reporter's name (as configured in the plugin config) in the
hierarchy, so for each reporter instance and for each registry the hierarchy is
unique. This should not require the "instance" attribute - I added it to solve
conflicts for MiniSolrCloudCluster where multiple reporters with the same name
and for the same registry name were created under different classloaders, but I
agree with you about the unpredictability of the name hierarchy that it
creates, so I'll change it.
New patch coming shortly.
> SolrInfoMBean-s category and hierarchy cleanup
> ----------------------------------------------
>
> Key: SOLR-9959
> URL: https://issues.apache.org/jira/browse/SOLR-9959
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: master (7.0)
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-9959.patch, SOLR-9959.patch
>
>
> SOLR-9947 changed categories of some of {{SolrInfoMBean-s}}, and it also
> added an alternative view in JMX, similar to the one produced by
> {{SolrJmxReporter}}.
> Some changes were left out from that issue because they would break the
> back-compatibility in 6.x, but they should be done before 7.0:
> * remove the old JMX view of {{SolrInfoMBean}}-s and improve the new one so
> that it's more readable and useful.
> * in many cases {{SolrInfoMBean.getName()}} just returns a FQCN, but it could
> be more informative - eg. for highlighter or query plugins this could be the
> symbolic name of a plugin that users know and use in configuration.
> * top-level categories need more thought. On one hand it's best to minimize
> their number, on the other hand they need to meaningfully represent the
> functionality of components that use them. SOLR-9947 made some cosmetic
> changes, but more discussion is necessary (eg. QUERY vs. SEARCHHANDLER)
> * we should consider removing some of the methods in {{SolrInfoMBean}} that
> usually don't return any useful information, eg. {{getDocs}}, {{getSource()}}
> and {{getVersion()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
