[
https://issues.apache.org/jira/browse/SOLR-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993494#comment-15993494
]
David Smiley commented on SOLR-1485:
------------------------------------
Apologies for reviewing late.
I'm looking at your documentation and what you committed.
* It's not documented that PayloadScoreQuery parses the value as a
SpanNearQuery (or SpanTermQuery if 1 term). Can you document this? Or if it's
too much implementation detail then document the subset that you think is
appropriate. (aside: it'd be nice if you let the user pick the query parser and
query like other query parsers do see BoostQParserPlugin and how it calls
subQuery).
* PayloadUtils.createSpanQuery: TokenStream implements Closeable and I see that
you called close(). But you should use try-with-resources to ensure it gets
called. (Personally I think of this immediately I see code that calls close();
I ask myself why not try-with-resources). From experience with buggy analysis
components (that I had a hand in writing ;-), this is a serious issue since a
forgotten close can actually put the entire Solr node into an inoperative
state! (due to stringent checks in TokenStream and that analysis components
get cached in ThreadLocal)
> Payload support
> ---------------
>
> Key: SOLR-1485
> URL: https://issues.apache.org/jira/browse/SOLR-1485
> Project: Solr
> Issue Type: New Feature
> Components: search
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 6.6, master (7.0)
>
> Attachments: PayloadTermQueryPlugin.java, payload_value_source.png,
> SOLR-1485.patch, SOLR-1485.patch, SOLR-1485.patch, SOLR-1485.patch,
> SOLR-1485.patch
>
>
> Solr has no support for Lucene's PayloadScoreQuery, yet it has support for
> indexing payloads (via DelimitedPayloadTokenFilter or
> NumericPayloadTokenFilter).
> This issue adds value source and query parser support for leveraging payloads
> created by those token filters.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
