[
https://issues.apache.org/jira/browse/SOLR-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993969#comment-15993969
]
Erik Hatcher commented on SOLR-1485:
------------------------------------
[~dsmiley] thanks again for your review - much appreciated.
* Query parsing - yeah, that was a tricky one and I opted for the simplest
thing that made sense given the available payloading of terms will be done by
way of DelimitedPayloadTokenFilter, so rather than trying phrase, boolean, and
other things just delegate to the analyzer and build a SpanTermQuery or
SpanNearQuery with zero slop and ordered. I just documented this on the cwiki
as well as a new upcoming commit that will add it to
PayloadUtils.createSpanQuery(). On the parsing decision I looked around to
find a way to create a SpanQuery conveniently (both PayloadScoreQuery and
SpanPayloadCheckQuery require a *SpanQuery*, not just a Query).
QueryBuilder.createSpanQuery() seemed the ticket, but alas it isn't public and
also suffers from the troubles with TokenStream API hurdles that you mention -
so I adapted it with the fixes that you spotted.
* Thanks for the try-with-resources suggestion - implemented it locally (and
running tests/precommit!) now but will commit that shortly.
* Back to query parsing - I'm definitely open to anything that will work, but
again a SpanQuery is the main constraint here. I don't quite see how subQuery
parsing could be used here. Any suggestions/improvements along these lines are
more than welcome. (my primary use case has been the {{payload()}} function so
the query parsing beyond the quite useful as-is SpanTermQuery wasn't a big
thrust)
> Payload support
> ---------------
>
> Key: SOLR-1485
> URL: https://issues.apache.org/jira/browse/SOLR-1485
> Project: Solr
> Issue Type: New Feature
> Components: search
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 6.6, master (7.0)
>
> Attachments: PayloadTermQueryPlugin.java, payload_value_source.png,
> SOLR-1485.patch, SOLR-1485.patch, SOLR-1485.patch, SOLR-1485.patch,
> SOLR-1485.patch
>
>
> Solr has no support for Lucene's PayloadScoreQuery, yet it has support for
> indexing payloads (via DelimitedPayloadTokenFilter or
> NumericPayloadTokenFilter).
> This issue adds value source and query parser support for leveraging payloads
> created by those token filters.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
