[ 
https://issues.apache.org/jira/browse/LUCENE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047515#comment-16047515
 ] 

ASF GitHub Bot commented on LUCENE-5644:
----------------------------------------

Github user synhershko commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/208#discussion_r121596530
  
    --- Diff: src/Lucene.Net/Document/Document.cs ---
    @@ -278,9 +279,17 @@ public string Get(string name)
                 return null;
             }
     
    -        /// <summary>
    -        /// Prints the fields of a document for human consumption. 
</summary>
    -        public override string ToString()
    +           /// <summary>
    +           /// Remove all fields from a document
    +           /// </summary>
    +           public void Clear()
    +           {
    +                   fields.Clear();
    +           }
    --- End diff --
    
    this seems unrelated?


> ThreadAffinityDocumentsWriterThreadPool should clear the bindings on flush
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-5644
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5644
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.8.1, 4.9, 6.0
>
>         Attachments: LUCENE-5644.patch, LUCENE-5644.patch, LUCENE-5644.patch, 
> LUCENE-5644.patch, LUCENE-5644.patch
>
>
> This class remembers which thread used which DWPT, but it never clears
> this "affinity".  It really should clear it on flush, this way if the
> number of threads doing indexing has changed we only use as many DWPTs
> as there are incoming threads.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to