[
https://issues.apache.org/jira/browse/LUCENE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047539#comment-16047539
]
ASF GitHub Bot commented on LUCENE-5644:
----------------------------------------
Github user vvdb commented on the issue:
https://github.com/apache/lucenenet/pull/208
>> align with the project's whitespace specs
I’ve been trying to find the project’s code formatting document, but was
unsuccessful.
>> Second, assuming we have no threading issues at the moment, how can we
be sure this doesn't introduce any?
We can be sure of nothing, since certainty is only as strong as the
assumptions it is based on.
However:
- the tests have been appropriately changed and use the new code,
and they all pass.
- On a more personal level (even though it means nothing since you
have to take my unverifiable word for it), this code has been in production use
these past 3 months on a 28-core machine, all of them writing to a single
IndexWriter for about a hundred million documents, repeatedly. No problems were
ever seen.
These things don’t show the absence of problems, but make me reasonably
confident that the code is sound.
Vincent
From: Itamar Syn-Hershko [mailto:[email protected]]
Sent: Tuesday, June 13, 2017 9:09 AM
To: apache/lucenenet <[email protected]>
Cc: Van Den Berghe, Vincent <[email protected]>; Author
<[email protected]>
Subject: Re: [apache/lucenenet] LUCENE-5644: switch to simpler LIFO thread
to ThreadState allocator d… (#208)
Thanks, that's an interesting one.
First, there's a lot of whitespace noise - can you remove it please? (align
with the project's whitespace specs)
Second, assuming we have no threading issues at the moment, how can we be
sure this doesn't introduce any? cc @NightOwl888<https://github.com/nightowl888>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on
GitHub<https://github.com/apache/lucenenet/pull/208#issuecomment-308027273>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/ARBXpku1AqOToF4KGaoBuQG8Pu83axMhks5sDjV4gaJpZM4N4A9a>.
> ThreadAffinityDocumentsWriterThreadPool should clear the bindings on flush
> --------------------------------------------------------------------------
>
> Key: LUCENE-5644
> URL: https://issues.apache.org/jira/browse/LUCENE-5644
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.8.1, 4.9, 6.0
>
> Attachments: LUCENE-5644.patch, LUCENE-5644.patch, LUCENE-5644.patch,
> LUCENE-5644.patch, LUCENE-5644.patch
>
>
> This class remembers which thread used which DWPT, but it never clears
> this "affinity". It really should clear it on flush, this way if the
> number of threads doing indexing has changed we only use as many DWPTs
> as there are incoming threads.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
