[ 
https://issues.apache.org/jira/browse/LUCENE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047517#comment-16047517
 ] 

ASF GitHub Bot commented on LUCENE-5644:
----------------------------------------

Github user synhershko commented on the issue:

    https://github.com/apache/lucenenet/pull/208
  
    Thanks, that's an interesting one.
    
    First, there's a lot of whitespace noise - can you remove it please? (align 
with the project's whitespace specs)
    
    Second, assuming we have no threading issues at the moment, how can we be 
sure this doesn't introduce any? cc @NightOwl888 


> ThreadAffinityDocumentsWriterThreadPool should clear the bindings on flush
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-5644
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5644
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.8.1, 4.9, 6.0
>
>         Attachments: LUCENE-5644.patch, LUCENE-5644.patch, LUCENE-5644.patch, 
> LUCENE-5644.patch, LUCENE-5644.patch
>
>
> This class remembers which thread used which DWPT, but it never clears
> this "affinity".  It really should clear it on flush, this way if the
> number of threads doing indexing has changed we only use as many DWPTs
> as there are incoming threads.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to