[ 
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignacio Vera updated LUCENE-7951:
---------------------------------
    Attachment: LUCENE-7951.patch

Attached a new patch with the proposed improvements.

- Clean up javadoc
- Geo3dBinaryCodec & Geo3dShapeFactory assume always a 
Geo3dSpatialContextFactory
- Remove unnecessary constructors in inner classes and made them private
- Override init() method in  Geo3dSpatialContextFactory. Currently only sphere 
and wsg84 planet models supported. What is the preferred syntax for a user 
defined planet model?
- Make GeoDistanceCalculator default but it can be override.
- Default planet model in factory: Sphere
- Added Shape suffix to all shapes


On another subject, [~daddywri], would it make sense to add a new GeoShape for 
degenerated paths (cutoff angle < MINIMUM_RESOLUTION)? 




> New wrapper classes for Geo3d
> -----------------------------
>
>                 Key: LUCENE-7951
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7951
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
>            Priority: Minor
>         Attachments: LUCENE-7951.patch, LUCENE-7951.patch
>
>
> Hi,
> After the latest developments in the Geo3d library, in particular:
> [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships 
> between GeoShapes
> [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of 
> GeoShapes.
> I propose a new set of wrapper classes which can be for example linked to 
> Solr as they implement their own SpatialContextFactory. It provides the 
> capability of indexing shapes with 
>  spherical geometry.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to