[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated LUCENE-7951: --------------------------------- Attachment: LUCENE-7951.patch Uploading the patch I intend to commit later tonight. I made more than trivial changes: * Reverted QueryEqualsHashCodeTest as it has nothing to do with Geo3d and the additions duplicated many test lines * Removed the redundant test lines in SpatialArgsTest so that it simply randomly picked the spatial context (potentially Geo3d). * Geo3dShapeFactory polygon / hole building wasn't quite right; the endHole method is supposed to return the PolygonBuilder of the *parent* / containing polygon, not some new builder. Admittedly the Spatial4j javadocs should have clarified that. I fixed this and made simplifications. * Geo3dShapeFactory addPoint; removed the points.contains(point) check on each input point as it's both not necessary (Geo3d internally has a filterPoints method/functionality) and expensive (O(N^2)). * Modified the Geo3dRptTest to not have the factory be a field of the test. The factory is supposed to be a very temporary thing only used to create the context. * Auto-formatted most of these source files. * Removed Geo3dDistanceCalculator.pointOnBearing2 as it was unused * Geo3dDistanceCalculator.distance: made both variants support Point subclasses that aren't Geo3dPointShape In at least one of these cases the problem was discovered by using it with some Solr tests. I intend to file a separate issue for Solr since it's both a test + convenience (spatialContextFactory="geo3d") + documentation > New wrapper classes for Geo3d > ----------------------------- > > Key: LUCENE-7951 > URL: https://issues.apache.org/jira/browse/LUCENE-7951 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras > Reporter: Ignacio Vera > Assignee: David Smiley > Priority: Minor > Attachments: LUCENE_7951_build.patch, LUCENE_7951_build.patch, > LUCENE-7951.patch, LUCENE-7951.patch, LUCENE-7951.patch > > > Hi, > After the latest developments in the Geo3d library, in particular: > [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships > between GeoShapes > [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of > GeoShapes. > I propose a new set of wrapper classes which can be for example linked to > Solr as they implement their own SpatialContextFactory. It provides the > capability of indexing shapes with > spherical geometry. > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org