[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160563#comment-16160563
]
Jason Gerlowski commented on SOLR-7871:
---------------------------------------
[~janhoy], I'm in the process of implementing the "2-step rocket" approach you
outlined above (absent opinions from anyone else, I decided to start on it).
I noticed that your current patch expands environment variables referenced in
the config file regardless of format (solr.in.sh, solr.in.cmd, solr.conf). I
wanted to raise the question of whether that was something you intentionally
chose to support in the new {{solr.conf}} format, or whether that was just a
by product of how you implemented your patch.
IMO, env-var expansion made sense when the configuration files were executable
bash/cmd scripts, but fits less well now that we're going with system
independent (and non-executable) file format.
Just wanted to throw the question out there...
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Labels: bin/solr
> Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
