[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165851#comment-16165851
]
Jan Høydahl commented on SOLR-7871:
-----------------------------------
+1 to env vars overriding the defaults if no solr.conf file is found.
Defaults are hard coded in shell scripts and/or SolrCLI. I was planning to
introduce a new defaults properties file for those, see [this
comment|https://issues.apache.org/jira/browse/SOLR-7871?focusedCommentId=15359601&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15359601],
which is not user editable but is visible in WEB-INF/classes, separate from
code. Don't know if this is feasible.
One of those defaults that the script currently hardcodes is {{GC_TUNE}}, which
can also be overridden. I wonder if we should consider introducing a separate
config file {{solr_jvm.conf}} where each line will be treated as a flag to be
passed directly to the JVM. This way we avoid one loooong {{SOLR_OPTS}} line in
{{solr.conf}}. Some of the values in this new file would still be commented out
to let SolrCLIConfig handle different defaults for Java8 and Java9 etc. What do
you think?
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Labels: bin/solr
> Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
