[ 
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172842#comment-16172842
 ] 

Jan Høydahl commented on SOLR-7871:
-----------------------------------

For SOLR_PORT, STOP_PORT and RMI_PORT, I guess it is sufficient to add a 
default for SOLR_PORT in the defaults-properties file and let the other ports 
be relative to that, unless specified as ENV or in solr.conf.

Perhaps we should support variable substitution in {{solr.conf}} and 
{{defaults.properties}} in the same way we do in solrconfig.xml, so one could 
write
{code}
solr.pid.dir = ${solr.tip}/bin
{code}
Or specify the defaults as relative paths, documenting that they are relative 
to SOLR_TIP?

Feel free to implement the constants in whatever way you feel makes most sense. 
It is always possible to change it later if we need.

> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
>                 Key: SOLR-7871
>                 URL: https://issues.apache.org/jira/browse/SOLR-7871
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>    Affects Versions: 5.2.1
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: bin/solr
>         Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, 
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable 
> batch files, but all they do is to set environment variables for the start 
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g. 
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by 
> {{SolrCLI.java}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to