[
https://issues.apache.org/jira/browse/SOLR-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219351#comment-16219351
]
Cassandra Targett commented on SOLR-11032:
------------------------------------------
I have no ability to comment on the merits of the test, but I checked out the
other parts of the patch:
* The content changes to the {{using-solrj.adoc}} page are very well done. I
walked away learning more about SolrJ than I knew before, which is really great.
* I tried to find a way to avoid copying the test file into the
{{solr-ref-guide/src/example}} and {{solr/build}} dirs, but remembered yet
again that Jekyll has a problem with files that aren't in its own build
directory. It seems there has to be a way out of this - the jekyll-asciidoc
project claims it's possible, but I spent an hour or so trying to figure it out
with various Jekyll/Asciidoctor params, but none of them worked. We can punt on
figuring that out for now unless anyone else has a quick idea ([~hossman]
maybe?).
* We can parameterize version numbers in .jar filenames and/or paths. In other
places of the docs we change, for example, {{solr-solrj-x.y.z.jar}} to
{{solr-solrj-\{solr-docs-version\}.0.jar}}, and during the build the Ref Guide
version is substituted to end up with: {{solr-solrj-7.1.0.jar}}. It won't be
exact for users on a X.x.1 or X.x.2, etc., release, but we've considered it
close enough (since we don't release new versions of the Ref Guide for those
bug fix releases).
In all, I'm +1 to commit this - I'll make the changes to parameterize the
version numbers and then do just that.
> Update solrj tutorial
> ---------------------
>
> Key: SOLR-11032
> URL: https://issues.apache.org/jira/browse/SOLR-11032
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: documentation, SolrJ, website
> Reporter: Karl Richter
> Attachments: SOLR-11032.patch, SOLR-11032.patch, SOLR-11032.patch
>
>
> The [solrj tutorial](https://wiki.apache.org/solr/Solrj) has the following
> issues:
> * It refers to 1.4.0 whereas the current release is 6.x, some classes are
> deprecated or no longer exist.
> * Document-object-binding is a crucial feature [which should be working in
> the meantime](https://issues.apache.org/jira/browse/SOLR-1945) and thus
> should be covered in the tutorial.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
