[ 
https://issues.apache.org/jira/browse/SOLR-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220812#comment-16220812
 ] 

Hoss Man commented on SOLR-11032:
---------------------------------

I'm not sure how cassandra will feel about having {{assert}} statements in the 
snippets that get included in the doc, but i'm +1 with the patch as is.

bq. those print-statements aren't really conveying any useful information to 
the reader. ...

well, particulaly because they were just toStringing the object -- but that's 
why i suggested changing them to print the actual field values (which the mock 
could assert matched our expectations)

bq. ... So instead of hiding our assertions behind mock print statements as 
Hoss suggested, I just removed them altogether. Or rather, I replaced them with 
the assertions you mentioned were previously lacking. If you'd still prefer the 
mock-print approach, I'm happy to take that approach too. 

I suspect in the long run we'll want some sort of mock so that the examples in 
the doc can look more like "real code" a user might do something with in an 
app, and less like a junit test? ... but who knows.  that can be iterated on in 
a new jira.

> Update solrj tutorial
> ---------------------
>
>                 Key: SOLR-11032
>                 URL: https://issues.apache.org/jira/browse/SOLR-11032
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: documentation, SolrJ, website
>            Reporter: Karl Richter
>         Attachments: SOLR-11032.patch, SOLR-11032.patch, SOLR-11032.patch, 
> SOLR-11032.patch
>
>
> The [solrj tutorial](https://wiki.apache.org/solr/Solrj) has the following 
> issues:
>   * It refers to 1.4.0 whereas the current release is 6.x, some classes are 
> deprecated or no longer exist.
>   * Document-object-binding is a crucial feature [which should be working in 
> the meantime](https://issues.apache.org/jira/browse/SOLR-1945) and thus 
> should be covered in the tutorial.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to