[ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284004#comment-16284004 ]
ASF GitHub Bot commented on LUCENE-8086: ---------------------------------------- Github user iverase commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/288#discussion_r155844958 --- Diff: lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/Geo3dShapeRectRelationTestCase.java --- @@ -16,29 +16,15 @@ */ package org.apache.lucene.spatial.spatial4j; -import java.util.ArrayList; -import java.util.List; - -import org.apache.lucene.spatial3d.geom.GeoPath; -import org.apache.lucene.spatial3d.geom.GeoPolygon; +import org.junit.Rule; +import org.junit.Test; import org.locationtech.spatial4j.TestLog; import org.locationtech.spatial4j.context.SpatialContext; -import org.locationtech.spatial4j.distance.DistanceUtils; import org.locationtech.spatial4j.shape.Circle; import org.locationtech.spatial4j.shape.Point; import org.locationtech.spatial4j.shape.RectIntersectionTestHelper; -import org.apache.lucene.spatial3d.geom.LatLonBounds; --- End diff -- I didn't dear to change it but that was the idea of the effort, I will remove Geo3d. > G3d wrapper: Improve circles for non spherical planets > ------------------------------------------------------ > > Key: LUCENE-8086 > URL: https://issues.apache.org/jira/browse/LUCENE-8086 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras > Reporter: Ignacio Vera > > Hi [~dsmiley], > The purpose of this ticket is to add a new circle shape (GeoExactCircle) for > non-spherical planets and therefore remove the method relate from > Geo3dCircleShape. The patch will include some simplifications on the wrapper > and some refactoring of the tests. > I will open shortly a pull request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org