[
https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289094#comment-16289094
]
Ignacio Vera commented on LUCENE-8086:
--------------------------------------
Hi [~dsmiley],
Here are my comments:
1) The javadocs can indeed be improved. I open a JIRA ticket and added a patch
with my suggestions.
2) Both shapes should be exposed and it should be the user that decides which
one fits his/her use case. It is perfectly fine to use GeoStandardCircle in
non-spherical planets if you are not so worried about accuracy as it is the
fastest shape. I can even imagine applications that use this type of circles
for big radius and then use GeoExactCircle where radius become small. The
implementation I have provided is maybe the more generic approach but it is a
decision I made and I think it belongs there .... maybe one day it is decided
to do it in a different way e.g. depending on radio size.
3) The CHANGES.txt note is fine. The other changes on the patch are just
cosmetic.
Thanks!
> G3d wrapper: Improve circles for non spherical planets
> ------------------------------------------------------
>
> Key: LUCENE-8086
> URL: https://issues.apache.org/jira/browse/LUCENE-8086
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Ignacio Vera
>
> Hi [~dsmiley],
> The purpose of this ticket is to add a new circle shape (GeoExactCircle) for
> non-spherical planets and therefore remove the method relate from
> Geo3dCircleShape. The patch will include some simplifications on the wrapper
> and some refactoring of the tests.
> I will open shortly a pull request.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
