[ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287650#comment-16287650 ]
ASF GitHub Bot commented on LUCENE-8086: ---------------------------------------- Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/288#discussion_r155938315 --- Diff: lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/ShapeRectRelationTestCase.java --- @@ -28,15 +28,15 @@ import static org.locationtech.spatial4j.distance.DistanceUtils.DEGREES_TO_RADIANS; -public abstract class Geo3dShapeRectRelationTestCase extends RandomizedShapeTestCase { +public abstract class ShapeRectRelationTestCase extends RandomizedShapeTestCase { protected final static double RADIANS_PER_DEGREE = Math.PI/180.0; @Rule public final TestLog testLog = TestLog.instance; protected int maxRadius = 180; - public Geo3dShapeRectRelationTestCase() { + public ShapeRectRelationTestCase() { super(SpatialContext.GEO); --- End diff -- I think the subclass should pass in the context. > G3d wrapper: Improve circles for non spherical planets > ------------------------------------------------------ > > Key: LUCENE-8086 > URL: https://issues.apache.org/jira/browse/LUCENE-8086 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras > Reporter: Ignacio Vera > > Hi [~dsmiley], > The purpose of this ticket is to add a new circle shape (GeoExactCircle) for > non-spherical planets and therefore remove the method relate from > Geo3dCircleShape. The patch will include some simplifications on the wrapper > and some refactoring of the tests. > I will open shortly a pull request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org