[
https://issues.apache.org/jira/browse/SOLR-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325893#comment-16325893
]
Shalin Shekhar Mangar commented on SOLR-11702:
----------------------------------------------
Thanks Dat. A few comments/questions:
# DUP.setupRequest skips replicas having terms. If I understand correctly, this
will mean that updates are no longer forwarded to replicas until they publish
themselves in recovery? Is that right?
# CreateCollectionCmd -- throw InterruptedException directly from the method
instead of trying to handle it here
# Mark LIR related classes/methods as deprecated -- those are more likely to
get attention right before 8.0 I think.
# ElectionContext -- Minor typo - "this replica is registered its term" --
s/is/has
# RecoveringCoreTermWatcher -- Shouldn't lastTermDoRecovery be set after
recovery completes? If not, how do we ensure that recoveries are stacked up?
# RecoveringCoreTermWatcher catches NullPointerException. Do a null check
instead.
# RecoveryStrategy -- why pingLeader? isn't it sufficient to use
ZkStateReader.getLeaderRetry as we used to do earlier?
# ZkCollectionTerms -- if getShard and remove methods need to be synchronized
then seems like close can interfere. Perhaps better to synchronize on the terms
map itself.
# Can you explain the purpose of "new".equals(cd.getCoreProperty("lirVersion",
"new"))) used in various places?
I'm still going through the rest of the changes. I'll add some more comments
later.
> Redesign current LIR implementation
> -----------------------------------
>
> Key: SOLR-11702
> URL: https://issues.apache.org/jira/browse/SOLR-11702
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Cao Manh Dat
> Assignee: Cao Manh Dat
> Priority: Major
> Attachments: SOLR-11702.patch, SOLR-11702.patch
>
>
> I recently looked into some problem related to racing between LIR and
> Recovering. I would like to propose a totally new approach to solve SOLR-5495
> problem because fixing current implementation by a bandage will lead us to
> other problems (we can not prove the correctness of the implementation).
> Feel free to give comments/thoughts about this new scheme.
> https://docs.google.com/document/d/1dM2GKMULsS45ZMuvtztVnM2m3fdUeRYNCyJorIIisEo/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
