[ 
https://issues.apache.org/jira/browse/SOLR-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326166#comment-16326166
 ] 

Shalin Shekhar Mangar commented on SOLR-11702:
----------------------------------------------

I'm not sure that ZkShardTerms.refreshTerms behaves correctly on ZK Reconnect. 
Say a watcher was set (numWatcher=1) but not fired and the zk client 
disconnects. Then on re-connect, the OnReconnectListener in ZkController fires 
which re-registers cores and calls refreshTerms again. Now watcher won't be 
initialized in this method (because numWatcher=1) and therefore won't be set on 
terms znode anymore. Can you please verify?

> Redesign current LIR implementation
> -----------------------------------
>
>                 Key: SOLR-11702
>                 URL: https://issues.apache.org/jira/browse/SOLR-11702
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Cao Manh Dat
>            Assignee: Cao Manh Dat
>            Priority: Major
>         Attachments: SOLR-11702.patch, SOLR-11702.patch
>
>
> I recently looked into some problem related to racing between LIR and 
> Recovering. I would like to propose a totally new approach to solve SOLR-5495 
> problem because fixing current implementation by a bandage will lead us to 
> other problems (we can not prove the correctness of the implementation).
> Feel free to give comments/thoughts about this new scheme.
> https://docs.google.com/document/d/1dM2GKMULsS45ZMuvtztVnM2m3fdUeRYNCyJorIIisEo/edit?usp=sharing



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to