[
https://issues.apache.org/jira/browse/SOLR-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335360#comment-16335360
]
Cao Manh Dat commented on SOLR-11702:
-------------------------------------
bq. LIRRollingUpdatesTest.testNewReplicaOldLeader – why is the proxy closed for
both leader and replica? Isn't closing for replica sufficient to force LIR?
Yeah, you're right, closing leader's proxy is not necessary. That call is only
for safety, I just want to simulate the real network partition between leader
and replica
bq. LIRRollingUpdatesTest calls TestInjection.reset() in tearDown but fault
injection isn't used anywhere in the test so it can be removed.
+1
bq. Javadocs for ZkShardTerms.ensureTermIsHigher says "Ensure that leader's
term is lower than some replica's terms" but shouldn't the leader have a higher
term? This is also mentioned in the design document "The idea of term is only
replicas (in the same shard) with highest term are considered healthy". The
impl is doing the opposite i.e. it is increasing the replica's term to
leaderTerm+1.
+1, the javadoc is miss typed
bq. Can you add javadocs to the various methods in the ZkShardTerms.Terms class?
Sure
> Redesign current LIR implementation
> -----------------------------------
>
> Key: SOLR-11702
> URL: https://issues.apache.org/jira/browse/SOLR-11702
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Cao Manh Dat
> Assignee: Cao Manh Dat
> Priority: Major
> Attachments: SOLR-11702.patch, SOLR-11702.patch
>
>
> I recently looked into some problem related to racing between LIR and
> Recovering. I would like to propose a totally new approach to solve SOLR-5495
> problem because fixing current implementation by a bandage will lead us to
> other problems (we can not prove the correctness of the implementation).
> Feel free to give comments/thoughts about this new scheme.
> https://docs.google.com/document/d/1dM2GKMULsS45ZMuvtztVnM2m3fdUeRYNCyJorIIisEo/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
