Hey Yonik, Have you read my e-mail? I just said that there is no need to add another sysprop as its already there! The default value for the sysprop is just a common-build.xml one-line change.
BTW, as I don't care about Solr tests most of the time, I disabled them completely on my local machine using lucene.build.properties in my user's home directory. Every developer can do the same on his own lucene.build.properties file (e.g. enable/disable bad apples). Just the default should be decided here. Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -----Original Message----- > From: Yonik Seeley [mailto:ysee...@gmail.com] > Sent: Thursday, February 22, 2018 12:17 AM > To: Solr/Lucene Dev <dev@lucene.apache.org> > Subject: Re: Test failures are out of control...... > > On Wed, Feb 21, 2018 at 6:13 PM, Uwe Schindler <u...@thetaphi.de> wrote: > >> > There are exactly three > >> > BadApple annotations in the entire code base at present, is there > >> > enough value in introducing another annotation to make it worthwhile? > >> > >> If we change BadApple tests to be executed by default for "ant test" > >> (but not for the most frequent jenkins jobs), then that would be fine. > >> Basically, add a -Dtests.disable-badapples and use that for the > >> jenkins jobs that email the list all the time. > > > > No need for a new sysprop. It's already there, just inverted! Configuring > Jenkins to enable disable them is trivial. > > The issue is that flakey tests should not be ignored by developers > running unit tests before committing new changes. That's the most > important point in time for test coverage. > > -Yonik > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
