[ 
https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374760#comment-16374760
 ] 

Hoss Man commented on SOLR-10912:
---------------------------------

comment/request from someone who hasn't really followed the progress here much 
but does use jira every day...

can we *PLEASE* rename the "Submit Patch" button to something else since it 
does not actually give you the power to "submit a patch" -- ie: clicking that 
button does nothing to enable me to upload a patch file from my computer.  that 
functionality is burried in the "More" menu as "Attach Files"

AFAICT the _true_ functionality of the current button is "Submit issue for 
automated Patch Review" -- so can we please change the button text to say that? 
 Likewise i would suggest changing the "Cancel Patch" button to something like 
"Cancel Automated Patch Review"

(If it's _also_ possible to add a top level button that *actually* triggers the 
"Attach Files" file selector, then by all means let's do that and give it text 
like "Submit Patch" or "Attach New Path")


> Adding automatic patch validation
> ---------------------------------
>
>                 Key: SOLR-10912
>                 URL: https://issues.apache.org/jira/browse/SOLR-10912
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Build
>            Reporter: Mano Kovacs
>            Priority: Major
>         Attachments: SOLR-10912.ok-patch-in-core.patch, 
> SOLR-10912.sample-patch.patch, SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or 
> other Apache projects are using (see link). This would ensure that every 
> patch passes a certain set of criterions before getting approved. It would 
> save time for developer (faster feedback loop), save time for committers 
> (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be 
> a good direction to start. This jira could be the board of discussing the 
> preferred solution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to